Re: CVS commit: pkgsrc/editors/jove/patches

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2019-09-06 at 15:00 BST, Christos Zoulas wrote:

> On Sep 6,  2:46pm, jperkin%joyent.com@localhost (Jonathan Perkin) wrote:
> -- Subject: Re: CVS commit: pkgsrc/editors/jove/patches
> 
> | * On 2019-09-02 at 09:51 BST, Christos Zoulas wrote:
> | 
> | > Module Name:      pkgsrc
> | > Committed By:     christos
> | > Date:             Mon Sep  2 08:51:29 UTC 2019
> | > 
> | > Modified Files:
> | >   pkgsrc/editors/jove/patches: patch-aa
> | > 
> | > Log Message:
> | > PR/54520: Greywolf: jove 'shell' fails with [Out of ptys!], use openpty(3).
> | 
> | Please don't apply patches that are clearly going to break a wide
> | range of OS.  Either write portable patches or use pkgsrc
> | infrastructure to add -lutil via on LDFLAGS.<OPSYS>.
> 
> Oh, I forgot about that... Will fix.

Thanks.  Looking at the failure it's actually breaking due to util.h
now also being pulled in unconditionally:

  http://us-east.manta.joyent.com/pkgsrc/public/reports/trunk/x86_64/20190905.0932/jove-4.16.0.74/build.log

4.16.0.70 built fine so I assume this is part of the same set of
changes (though it also fails with the same "Out of ptys!" error).

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com