pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Python 3.x, .py[co] files and print-PLIST not ordered



Leonardo Taccari <leot%NetBSD.org@localhost> writes:

> Hello Greg,
>
> Greg Troxel writes:
>> [...]
>> Log Message:
>> devel/py-ruamel-yaml: Sort PLIST
>>
>> No functional change; PLIST was not sorted per print-PLIST, making
>> updates difficult.
>> [...]
>
> Unfortunately I think that print-PLIST when using Python 3.x doesn't
> "sort" the PLIST, i.e. the several entries aren't properly ordered as
> usual and `pkglint -Wall' probably warns about that too (the root
> problem is that Python 3.x bytecode and corresponding PRINT_PLIST_AWK
> make them not ordered as espected).

On the PLIST after I adjusted it, pkglint -Wall did not complain.
However, I went and checked the old version and pkglint -Wall also did
not complain.

> I would keep the PLIST ordered (as pkglint) to ease reading possible
> diffs (and AFAIT that's what most Python packages are currently
> doing).

I can see what you mean somewhat, in that the print-PLIST output has

bar.pyo
bar.pyc
foo.pyo
foo.pyc
bar.py
foo.py

and I think you would like

bar.py
bar.pyo
bar.pyc
foo.py
foo.pyo
foo.pyc

So I will refrain from making more changes like this.

It really seems like if there is a canonical order then print-PLIST
should output it and secondarily pkglint should check it.

My goal is that on future updates with actual changes, that

  make print-PLIST > A
  diff -u PLIST A

have useful output, meaning showing me only actual changes.



Home | Main Index | Thread Index | Old Index