CVS commit: pkgsrc/lang/python27

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Tue Mar 26 16:12:28 UTC 2019

Modified Files:
        pkgsrc/lang/python27: Makefile

Log Message:
lang/python27: Add comments about NIS detection

The logic to determine inclusion of NIS PLIST entries is confusing.
Add comments to explain some and question some.

This is a comment-only change.


To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78 pkgsrc/lang/python27/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/lang/python27/Makefile
diff -u pkgsrc/lang/python27/Makefile:1.77 pkgsrc/lang/python27/Makefile:1.78
--- pkgsrc/lang/python27/Makefile:1.77  Tue Mar  5 12:43:40 2019
+++ pkgsrc/lang/python27/Makefile       Tue Mar 26 16:12:28 2019
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.77 2019/03/05 12:43:40 adam Exp $
+# $NetBSD: Makefile,v 1.78 2019/03/26 16:12:28 gdt Exp $
 
 .include "dist.mk"
 
@@ -104,6 +104,8 @@ PLIST.qt=   yes
 .endif
 
 .if ${OPSYS} == "IRIX"
+# Assume that IRIX (and IRIX alone) does not support a libpython.so.
+# Assume that 32-bit IRIX has NIS and 64-bit IRIX does not.
 .  if ${ABI} == "64"
 PLIST.no-nis=  yes
 .  else
@@ -111,9 +113,14 @@ PLIST.nis= yes
 .  endif
 .else
 PLIST.dll=     yes
+# Determine if lib-dynload/nis.so (PLIST.nis) or
+# lib-dynload/nis-failed.so (PLIST.no-nis) will be built.
 .  if ${OPSYS} == "MirBSD" || "${OS_VARIANT}" == "chromeos"
 # neither nis nor no-nis
 .  elif ${OPSYS} != "NetBSD" || exists(/usr/bin/ypcat)
+# \todo Explain the "!= NetBSD"; that seems to declare that any
+# remaining system other than NetBSD will have NIS, even if ypcat is
+# missing.
 PLIST.nis=     yes
 .  else
 PLIST.no-nis=  yes