Re: CVS commit: pkgsrc/graphics/xv

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Fri, Feb 22, 2019 at 12:14:55AM +0900, Izumi Tsutsui wrote:
> joerg@ wrote:
> 
> > On Thu, Feb 21, 2019 at 01:37:14AM +0000, Izumi Tsutsui wrote:
> > > Module Name:      pkgsrc
> > > Committed By:     tsutsui
> > > Date:             Thu Feb 21 01:37:14 UTC 2019
> > > 
> > > Modified Files:
> > >   pkgsrc/graphics/xv: Makefile distinfo
> > >   pkgsrc/graphics/xv/patches: patch-ac patch-ad
> > > 
> > > Log Message:
> > > xv: make ghostscript support optional and disable it by default.
> > 
> > Does it really use gs for non-ps? Because otherwise I would just drop
> > the dependency by default and keep the code as is.
> 
> I'm not sure what's your point, but there is no configure so you have
> to edit config.h and undef GS_PATH to disable ghostscript support.
> 
> If GS_PATH is defined xv invokes ghostscript and shows the processed
> postscript image in the graphic window.
> If GS_PATH is not defined xv shows postscript text in the text window.
> 
> Maybe you can ask a person who added the dependencies:
>  http://gnats.netbsd.org/51378

Yeah, I think the PR change should just be reverted as default, i.e.
- include all the code for invoking gs if it is available
- only hard-depend on it if the option is set

Joerg