Re: CVS commit: pkgsrc/multimedia

[maya%netbsd.org@localhost]

Because it's been there since ffmpeg010 was the latest version without a
rationale. Even though it means less things than I initially read I
don't think it's reasonable to turn off optimizations as a policy.

On Mon, Dec 10, 2018 at 09:15:46AM +0100, Adam wrote:
> Why???
> Optimisations override compiler flags provided by PkgSrc.
> 
> Please, revert.
> 
> Adam
> 
> 
> > Wiadomość napisana przez Maya Rashish <maya%netbsd.org@localhost> w dniu 09.12.2018, o godz. 23:22:
> > 
> > Module Name:        pkgsrc
> > Committed By:       maya
> > Date:               Sun Dec  9 22:22:27 UTC 2018
> > 
> > Modified Files:
> >     pkgsrc/multimedia/ffmpeg3: Makefile Makefile.common
> >     pkgsrc/multimedia/ffplay3: Makefile
> > 
> > Log Message:
> > ffplay3, ffmpeg3: don't disable optimizations. they are runtime detected.
> > 
> > bump PKGREVISION
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.38 -r1.39 pkgsrc/multimedia/ffmpeg3/Makefile
> > cvs rdiff -u -r1.33 -r1.34 pkgsrc/multimedia/ffmpeg3/Makefile.common
> > cvs rdiff -u -r1.14 -r1.15 pkgsrc/multimedia/ffplay3/Makefile
> > 
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> > 
> > Modified files:
> > 
> > Index: pkgsrc/multimedia/ffmpeg3/Makefile
> > diff -u pkgsrc/multimedia/ffmpeg3/Makefile:1.38 pkgsrc/multimedia/ffmpeg3/Makefile:1.39
> > --- pkgsrc/multimedia/ffmpeg3/Makefile:1.38 Fri Nov 23 08:06:28 2018
> > +++ pkgsrc/multimedia/ffmpeg3/Makefile      Sun Dec  9 22:22:27 2018
> > @@ -1,7 +1,7 @@
> > -# $NetBSD: Makefile,v 1.38 2018/11/23 08:06:28 ryoon Exp $
> > +# $NetBSD: Makefile,v 1.39 2018/12/09 22:22:27 maya Exp $
> > 
> > PKGNAME=    ${DISTNAME:S/ffmpeg/ffmpeg3/}
> > -PKGREVISION=       2
> > +PKGREVISION=       3
> > MAINTAINER= pkgsrc-users%NetBSD.org@localhost
> > HOMEPAGE=   http://ffmpeg.mplayerhq.hu/
> > COMMENT=    Decoding, encoding and streaming software (v3.x)
> > 
> > Index: pkgsrc/multimedia/ffmpeg3/Makefile.common
> > diff -u pkgsrc/multimedia/ffmpeg3/Makefile.common:1.33 pkgsrc/multimedia/ffmpeg3/Makefile.common:1.34
> > --- pkgsrc/multimedia/ffmpeg3/Makefile.common:1.33  Sat Nov  3 08:06:46 2018
> > +++ pkgsrc/multimedia/ffmpeg3/Makefile.common       Sun Dec  9 22:22:27 2018
> > @@ -1,4 +1,4 @@
> > -# $NetBSD: Makefile.common,v 1.33 2018/11/03 08:06:46 adam Exp $
> > +# $NetBSD: Makefile.common,v 1.34 2018/12/09 22:22:27 maya Exp $
> > # used by multimedia/ffmpeg3/Makefile
> > # used by multimedia/ffplay3/Makefile
> > 
> > @@ -17,7 +17,6 @@ USE_TOOLS+=               gmake pod2man perl pkg-conf
> > HAS_CONFIGURE=              yes
> > CONFIGURE_ARGS+=    --cc=${CC:Q}
> > CONFIGURE_ARGS+=    --disable-debug
> > -CONFIGURE_ARGS+=   --disable-optimizations
> > CONFIGURE_ARGS+=    --disable-stripping
> > CONFIGURE_ARGS+=    --enable-gpl
> > CONFIGURE_ARGS+=    --enable-libxml2
> > 
> > Index: pkgsrc/multimedia/ffplay3/Makefile
> > diff -u pkgsrc/multimedia/ffplay3/Makefile:1.14 pkgsrc/multimedia/ffplay3/Makefile:1.15
> > --- pkgsrc/multimedia/ffplay3/Makefile:1.14 Fri Nov 23 08:06:31 2018
> > +++ pkgsrc/multimedia/ffplay3/Makefile      Sun Dec  9 22:22:27 2018
> > @@ -1,7 +1,7 @@
> > -# $NetBSD: Makefile,v 1.14 2018/11/23 08:06:31 ryoon Exp $
> > +# $NetBSD: Makefile,v 1.15 2018/12/09 22:22:27 maya Exp $
> > 
> > PKGNAME=    ${DISTNAME:S/ffmpeg/ffplay3/}
> > -PKGREVISION=       1
> > +PKGREVISION=       2
> > MAINTAINER= pkgsrc-users%NetBSD.org@localhost
> > HOMEPAGE=   https://ffmpeg.org/
> > COMMENT=    Simple SDL frontend for FFmpeg
> > 
>