Re: CVS commit: pkgsrc/lang

[Takahiro Kambe <taca%NetBSD.org@localhost>]

Hi,

I've noticed this commit while trying to update php* to new version.

In message <20181207015453.347F6FB16%cvs.NetBSD.org@localhost>
        on Fri, 7 Dec 2018 01:54:53 +0000,
        "Emmanuel Dreyfus" <manu%netbsd.org@localhost> wrote:
> Module Name:  pkgsrc
> Committed By: manu
> Date:         Fri Dec  7 01:54:53 UTC 2018
...
> The fix is to disable PHP's built-in libslite3 and always use an external,
> shared libsqlite3.
On NetBSD 8.0_STABLE/amd64, your change creates extra files, such as
lib/php/20160303/sqlite3.so and php71 is broken now.  (This sqlite3.so
is not linked with sqlite3's shared library.)

And it introduce runtime dependency for databases/sqlite3 to php71.

I belive that it is better to create separate database/php-sqlite3
package and avoid introduce such dependency.  (And there is ready
databases/php-sqlite3 package my work area.)

$ pwd
/usr/pkgsrc/databases/php-sqlite3
$ ls -l work.edge/.destdir/usr/pkg/lib/php/20160303/sqlite3.so
-rwxr-xr-x  1 taca  taca  64744 Dec  7 17:31 work.edge/.destdir/usr/pkg/lib/php/20160303/sqlite3.so
$ ldd work.edge/.destdir/usr/pkg/lib/php/20160303/sqlite3.so
work.edge/.destdir/usr/pkg/lib/php/20160303/sqlite3.so:
        -lsqlite3.0 => /usr/pkg/lib/libsqlite3.so.0
        -lz.1 => /usr/lib/libz.so.1
        -lc.12 => /usr/lib/libc.so.12
        -lm.0 => /usr/lib/libm.so.0
        -lpthread.1 => /usr/lib/libpthread.so.1

-- 
Takahiro Kambe <taca%NetBSD.org@localhost>