Re: CVS commit: pkgsrc/comms/conserver8

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Thu, Jun 16, 2016 at 10:35:36AM -0500, Eric Schnoebelen wrote:
> Joerg Sonnenberger writes:
> - On Wed, Jun 15, 2016 at 11:02:10PM +0000, Eric Schnoebelen wrote:
> - > Module Name:      pkgsrc
> - > Committed By:     schnoebe
> - > Date:             Wed Jun 15 23:02:10 UTC 2016
> - > 
> - > Modified Files:
> - >   pkgsrc/comms/conserver8: PLIST options.mk
> - > 
> - > Log Message:
> - > options.mk:
> - >     Don't default on inet6, since the inet6 code in conserver8 depends
> - >     on some Linux-isms (ipv6 sockets can accept ipv4 packets.)
> - 
> - Are you sure that it is more than just requiring IPV6_V6ONLY to be
> - disabled? At the very least, I can't find anything in the code otherwise
> - and I consider this a regression...
> 
> rizzo complained that the inet6 option didn't work for him as a
> default.  I took a quick fix to get it back to a universal
> operating state, with a plan on digging much deeper into the
> code later when I have more time.
> 
> If someone else wants to dig in and handle it, go for it!

Well, you created a functional regressions for all users OOB and for
binary package user specifically. From the code, it seems like it would
only matter if you are using a symbolic name. So yes, from incomplete
analysis, I think this should be reverted before the branch.

Joerg