pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/devel/py-thrift



On Tue, Mar 29, 2016 at 10:49:34PM +0000, Pierre Pronchery wrote:
> Module Name:  pkgsrc
> Committed By: khorben
> Date:         Tue Mar 29 22:49:34 UTC 2016
> 
> Modified Files:
>       pkgsrc/devel/py-thrift: PLIST
> 
> Log Message:
> Register missing file in the PLIST
> 
> This fixes the build where the C extension built successfully. In turn, it
> will break where the C extension failed to build. I believe it is better to
> fail when actually failing, and this is a leaf package, so I am going ahead
> with this - and then the issues when the C extension should be corrected
> instead (when observed).

Eh, this change is at least 50% wrong. The primary question is whether
this module works with Python 3.x (C extension or not). If it does, the
entry should be condition, if it doesn't, the package should be black
listed for Python 3.x. Random changing the PLIST is just wrong.

Joerg



Home | Main Index | Thread Index | Old Index