Re: CVS commit: pkgsrc/x11/gtk3

[Richard PALO <richard.palo%free.fr@localhost>]

Le 19/07/14 23:02, Patrick Welche a écrit :
> On Sat, Jul 19, 2014 at 08:32:16PM +0000, Richard PALO wrote:
> > Module Name:    pkgsrc
> > Committed By:   richard
> > Date:           Sat Jul 19 20:32:16 UTC 2014
> >
> > Modified Files:
> >         pkgsrc/x11/gtk3: Makefile
> >
> > Log Message:
> > fix CONFIG_SHELL for bash to correctly use TOOLS_PATH
>
> Above it, it says:
>
>   # XXX there is a subtle bashism in "configure" or a bug in NetBSD's sh
>
> Does anyone know what that is refering to?
>
> Cheers,
>
> Patrick
Hi Patrick, I noticed that in gtk2 the CONFIG_SHELL is commented out, 
and that works for me as well for gtk3 on my current platforms, but just 
in case there was something subtle at hand, I didn't want to presume it 
worked on all NetBSD platforms as well.

What is certain is that there seem to be a number of packages needing a 
guiding hand for CONFIG_SHELL...(output from prior to updating gtk3):
> richard@devzoneX:~/src/pkgsrc$ git grep CONFIG_SHELL |grep bash
> archivers/libarchive/files/aclocal.m4:      # if, for instance, CONFIG_SHELL is 
> bash and it inherits a
> archivers/libarchive/files/configure:      # if, for instance, CONFIG_SHELL is 
> bash and it inherits a
> chat/bitchx/Makefile:CONFIG_SHELL=              ${TOOLS_PATH.bash}
> databases/datadraw/Makefile:CONFIG_SHELL=               ${TOOLS_PATH.bash}
> databases/mysql51-client/Makefile.common:CONFIG_SHELL=          
> ${TOOLS_PATH.bash}
> databases/mysql55-client/Makefile.common:CONFIG_SHELL=          
> ${TOOLS_PATH.bash}
> databases/mysql56-client/Makefile.common:CONFIG_SHELL=          
> ${TOOLS_PATH.bash}
> doc/guide/files/platforms.xml:CONFIG_SHELL=   ${LOCALBASE}/bin/bash
> doc/pkgsrc.html:CONFIG_SHELL=   ${LOCALBASE}/bin/bash
> doc/pkgsrc.txt:CONFIG_SHELL=   ${LOCALBASE}/bin/bash
> games/gltron/patches/patch-ab:       # if, for instance, CONFIG_SHELL is bash 
> and it inherits a
> graphics/evas/patches/patch-configure:-      # if, for instance, CONFIG_SHELL 
> is bash and it inherits a
> graphics/evas/patches/patch-configure:+ # if, for instance, CONFIG_SHELL is 
> bash and it inherits a
> graphics/libgexiv2/Makefile:CONFIG_SHELL=               bash
> graphics/shotwell-gtk3/Makefile:CONFIG_SHELL=           bash
> graphics/shotwell/Makefile:CONFIG_SHELL=                bash
> lang/clisp/Makefile:CONFIG_SHELL=       ${TOOLS_PATH.bash}
> lang/gcc44/Makefile:CONFIG_SHELL=               ${TOOLS_PATH.bash}
> lang/gcc45/Makefile:CONFIG_SHELL=               ${TOOLS_PATH.bash}
> lang/gcc46/Makefile:CONFIG_SHELL=               ${TOOLS_PATH.bash}
> lang/perl5/Makefile:CONFIG_SHELL=       ${TOOLS_PATH.bash}
> multimedia/libmediainfo/Makefile:CONFIG_SHELL=          bash
> net/firewalk/patches/patch-ad:       # if, for instance, CONFIG_SHELL is bash 
> and it inherits a
> pkgtools/pkg_install-info/files/aclocal.m4:      # if, for instance, 
> CONFIG_SHELL is bash and it inherits a
> sysutils/dvdisaster/Makefile:CONFIG_SHELL=              ${TOOLS_PATH.bash}
> sysutils/libgtop/Makefile:CONFIG_SHELL=         bash
> x11/elementary/patches/patch-ab:-      # if, for instance, CONFIG_SHELL is bash 
> and it inherits a
> x11/elementary/patches/patch-ab:+       # if, for instance, CONFIG_SHELL is 
> bash and it inherits a
> x11/gtk2/Makefile:#CONFIG_SHELL=                bash
> x11/gtk3/Makefile:CONFIG_SHELL=         bash