CVS commit: pkgsrc/editors/mflteco

["David A. Holland" <dholland%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   dholland
Date:           Thu Dec 27 06:13:20 UTC 2012

Modified Files:
        pkgsrc/editors/mflteco: Makefile distinfo
        pkgsrc/editors/mflteco/patches: patch-aa patch-ab patch-ac patch-ad
            patch-ae
Added Files:
        pkgsrc/editors/mflteco/patches: patch-te__data.c patch-te__exec0.c
            patch-te__exec1.c patch-te__fxstub.c patch-te__main.c
            patch-te__srch.c patch-te__subs.c patch-te__utils.c
            patch-te__window.c

Log Message:
Clean up legacy C.
Now passes gcc -Wall -Wextra -Wmissing-declarations -Wwrite-strings on gcc45.
May build with clang now too.

Changes:
   - use standard headers
   - don't declare own errno, fopen(), getenv(), or malloc()
   - declare own functions
   - declare void functions void
   - avoid implicit int
   - use C89
   - use some const
   - use some static
   - fix signed/unsigned mismatches
   - call execl() properly
   - don't cast return value of malloc
   - initialize struct sigaction correctly
   - use <ctype.h> functions correctly
   - don't index arrays with (signed) char
   - don't put function declarations inside function bodies
   - patch up two uninitialized variables
   - silence some compiler warnings that are not bugs
   - remove some unused objects
and:
   - add patch comments for preexisting patches
   - correct some minor pkglint

As a couple of these things fixed bugs (e.g. the execl calls), bump
PKGREVISION.


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 pkgsrc/editors/mflteco/Makefile
cvs rdiff -u -r1.2 -r1.3 pkgsrc/editors/mflteco/distinfo
cvs rdiff -u -r1.1.1.1 -r1.2 pkgsrc/editors/mflteco/patches/patch-aa \
    pkgsrc/editors/mflteco/patches/patch-ab \
    pkgsrc/editors/mflteco/patches/patch-ac
cvs rdiff -u -r1.1 -r1.2 pkgsrc/editors/mflteco/patches/patch-ad \
    pkgsrc/editors/mflteco/patches/patch-ae
cvs rdiff -u -r0 -r1.1 pkgsrc/editors/mflteco/patches/patch-te__data.c \
    pkgsrc/editors/mflteco/patches/patch-te__exec0.c \
    pkgsrc/editors/mflteco/patches/patch-te__exec1.c \
    pkgsrc/editors/mflteco/patches/patch-te__fxstub.c \
    pkgsrc/editors/mflteco/patches/patch-te__main.c \
    pkgsrc/editors/mflteco/patches/patch-te__srch.c \
    pkgsrc/editors/mflteco/patches/patch-te__subs.c \
    pkgsrc/editors/mflteco/patches/patch-te__utils.c \
    pkgsrc/editors/mflteco/patches/patch-te__window.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.