Re: CVS commit: pkgsrc/devel/cmph

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Fri, Oct 12, 2012 at 06:12:03PM +0200, Thomas Klausner wrote:
> On Fri, Oct 12, 2012 at 05:35:57PM +0200, Alistair Crooks wrote:
> > Please stop doing this (removing -Werror) now - it is not fixing
> > anything, and will make things harder in future to spot problems.
> 
> I disagree. Warnings should not automatically cause errors; this
> should not be set in released software, just like
> G_DISABLE_DEPRECATED, because you never know when your next release
> will be or what compilers on what platforms warn about which possible
> problems.

I both agree and disagree on this. In most cases the correct fix is to
just selectively disable the warnings. This is what I generally do with
clang, but sometimes it is hard, since e.g. -Wall is appended last and
the GNU semantic of -Wall being applied first is correctly not followed
by clang. So yes, removing -Werror is a sledge hammer and should be
avoided, but it is sometimes by far the easiest approach.

Joerg