Re: CVS commit: pkgsrc/net/coda

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Sun, Jul 22, 2012 at 08:50:59PM +0200, John Marino wrote:
 > To really do this in a generic way, we probably need to remove the
 > config.h.in patch and duplicate the resolution_rename.cc fix to
 > every file that mentions MAXNAMLEN.  Maybe a better way is to
 > create one header to defined MAXNAMLEN (if necessary) and add that
 > header to every file that needs it.

The correct approach, if upstream is not dead/comatose, is to massedit
all references to MAXNAMLEN to be NAME_MAX and send the resulting
patch upstream.

It would also be a good idea to wade in and make sure that none of the
MAXNAMLEN uses are really supposed to be CODA_MAXNAMLEN and vice
versa. I started to check this yesterday but it becomes a hassle,
because at least one of the key places has char[16] and a comment
saying that extra memory is allocated off the end of the structure for
longer names. (Ew.)

-- 
David A. Holland
dholland%netbsd.org@localhost