Re: CVS commit: pkgsrc/lang/gcc46

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Sat, Apr 07, 2012 at 09:41:00PM +1200, Steven Drake wrote:
 > > > Module Name:     pkgsrc
 > > > Committed By:    sbd
 > > > Date:            Wed Apr  4 22:20:37 UTC 2012
 > > > 
 > > > Modified Files:
 > > >  pkgsrc/lang/gcc46: options.mk
 > > > 
 > > > Log Message:
 > > > Rename option "gcc-c++" to "gcc-cpp" (with legacy support) as pkglint
 > > > complains with: "gcc-c++" is not a valid option name.
 > > > 
 > > > 
 > > > To generate a diff of this commit:
 > > > cvs rdiff -u -r1.4 -r1.5 pkgsrc/lang/gcc46/options.mk
 > > > 
 > > > Please note that diffs are not public domain; they are subject to the
 > > > copyright notices on the relevant files.
 > > > 
 > > 
 > > Was"gcc-c++" actually working as an option?
 > 
 > Yes it was.
 > 
 > > If so, the problem is with pkglint, not the option name, and it should be
 > > pkglint that is fixed.
 > 
 > I was going by the assumption that pkglint was right and I think whether its
 > changed or not needs to be decided by the pmc.

pkglint is frequently wrong these days. If in doubt, ask on tech-pkg.

anyhow, if you don't want to restore "gcc-c++" as the option without
discussion, please change it to gcc-cplusplus right away and have that
change pulled up to the branch... the way it is right now it's going
to confuse people.

-- 
David A. Holland
dholland%netbsd.org@localhost