Re: CVS commit: pkgsrc/devel/scmgit-base

[Hans Rosenfeld <rosenfeld%grumpf.hope-2000.org@localhost>]

On Fri, Feb 17, 2012 at 09:54:17AM -0500, Greg Troxel wrote:
> 
> "Hans Rosenfeld" <hans%netbsd.org@localhost> writes:
> 
> > Module Name:        pkgsrc
> > Committed By:       hans
> > Date:               Fri Feb 17 13:54:02 UTC 2012
> >
> > Modified Files:
> >     pkgsrc/devel/scmgit-base: Makefile
> >
> > Log Message:
> > Fix build on SunOS.
> 
> Can you explain why this is needed (in this case, and in general, in the
> commit messages)?

Yes, of course I can. Obviously it fails to link without it.

Normally this should be handled by the BUILDLINK_LDADD.iconv variable in
converters/libiconv/buildlink3.mk, but that's been broken for years and
even after many hours trying to debug this I have no idea why. So I'll
just use the same fix that's been in other packages for ages.

>   While I can more or less see that this change
> shouldn't affect other than SunOS (presumably Solaris only these days),
> I don't follow why this is needed, and if so why it isn't an upstream
> bug that should be reported there and have a tracker URL (ok, this is
> git, a mailinglist post) in a comment.

It builds without problems outside of pkgsrc, so I don't really see why
I should report it.


Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown