Re: CVS commit: pkgsrc/devel/fossil

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Mon, Jan 25, 2010 at 08:58:34AM +0100, Joerg Sonnenberger wrote:
> > > Split date from time in version number.
> > > joerg says pkgsrc is limited to 32bit for the version number.
> > 
> > That's a pity - the code I wrote and contributed for the Dewey
> > matching uses 64-bit integers, so I have no idea why there is now an
> > arbitrary 32-bit limit - makes me wish I'd committed vtest and its
> > regression tests.  And been more vigilant about all the renovation
> > and improvements.
> 
> You might want to refresh your memory. More precisely, the limit is
> 31bit as the version array is using signed integers...

http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/pkg_install/lib/Attic/str.c?annotate=1.32&only_with_tag=MAIN

        Revision 1.32 / (download) - annotate - [select for diffs], Wed Jan 9 
16:17:08 2002 UTC (8 years ago) by agc
        Branch: MAIN
        Changes since 1.31: +199 -66 lines
        Diff to previous 1.31 (colored)

        Pull in a much simplified version of the vtest functionality. This new
        functionality adds recognition of '_' and "pl" as pseudonyms for '.',
        so that 1.2p2 == 1.2.2, and adds recognition of "pl" and "rc" strings,
        which stand for "patchlevel" and "release candidate" respectively.

        In addition, this version should handle alphabetic characters properly
        (so that 1.2e == 1.2.5)

        Normal NetBSD revision number processing has been retained (and is 
always
        compared after all other tests have been performed).

        64-bit integers are used internally for each component of the version
        number.


lines 108 and 109:

        !           103:
        !           104: /* this struct defines a version number */
        !           105: typedef struct arr_t {
        !           106:        unsigned        c;              /* # of version 
numbers */
        !           107:        unsigned        size;           /* size of 
array */
        !           108:        int64_t        *v;              /* array of 
decimal numbers */
        !           109:        int64_t         netbsd;         /* any "nb" 
suffix */
        !           110: } arr_t;

Regards,
Alistair