Re: CVS commit: pkgsrc/news/inn

["S.P.Zeidler" <spz%serpens.de@localhost>]

Hi,

Thus wrote Geoff Wing (gcw%pobox.com@localhost):

> On Thursday 2009-09-24 13:01 +1000, Geoff Wing output:
> :On Tuesday 2009-09-22 13:17 +0000, S.P.Zeidler output:
> ::Update of the INN package to the latest stable version (2.5.0).
> :Untested?

Only verified to actually build, install and deinstall. My newsserver is
an Amiga, compiling takes its time (and I didn't want to let the upgrade
slip by yet another quarter). I didn't expect anybody to pounce on the
update and do my testing for me, much appreciated. :)

Re PLIST and sysconfdir, ACK.

> +++ perl/INN/Config.pm.in     2009-09-25 10:53:28.000000000 +1000
[...]
>  ##  Then, process the variables provided by innconfval.
>  my @INNCONFVAR = ();
> -my @values = `${exec_prefix}/bin/innconfval -p`;

And there I was being happy about getting rid of @prefix@/bin and
$(PATHNEWS)/bin, see what snuck in instead. :}

No need to add bindir to @DIRVAR btw, since $newsbin is already there
and is the same directory, via pathbin. So due to no extra uses,
we might as well not use a rather visible variable and instead
hardcode that one path directly, like we do for all the innshellvars*

Any more misses? Due to unplanned interference I still haven't gotten
around to upgrading my own server.

regards,
        spz
-- 
spz%serpens.de@localhost (S.P.Zeidler)