Re: CVS commit: pkgsrc/mk

["Jared D. McNeill" <jmcneill%invisible.ca@localhost>]

OBATA Akio wrote:
> On Fri, 23 Jan 2009 21:12:45 +0900, Jared D. McNeill 
> <jmcneill%invisible.ca@localhost> wrote:
>
> > Ok, I just read the comment in dlopen.builtin.mk; please try to provide
> > more detail in your commit messages next time around :)
>
> Yes, it's known issue, and just update the pattern :(

Ok, I wrote a test case for this bug (extract and run test.sh):

  http://www.netbsd.org/~jmcneill/dltest.tar

It looks like your change is a bit too aggressive;

$ uname -srm && ./test.sh 

NetBSD 4.0_STABLE i386
 ==> building executable (dltest)
dltest:
        -lc.12 => /usr/lib/libc.so.12
liblib1.so:
        -lpthread.0 => /usr/lib/libpthread.so.0
[1]   Abort trap (core dumped) ./dltest

$ uname -srm && ./test.sh 

NetBSD 5.0_BETA i386
 ==> building executable (dltest)
dltest:
        -lc.12 => /usr/lib/libc.so.12
liblib1.so:
        -lc.12 => /usr/lib/libc.so.12
        -lpthread.0 => /usr/lib/libpthread.so.0
call function()
in liblib1, self=0xbfbc0000
ret function()

$ uname -srm && ./test.sh 


NetBSD 5.99.5 amd64
 ==> building executable (dltest)
dltest:
        -lc.12 => /usr/lib/libc.so.12
liblib1.so:
        -lc.12 => /usr/lib/libc.so.12
        -lpthread.0 => /usr/lib/libpthread.so.0
call function()
in liblib1, self=0x7f7ffffc0000
ret function()

Cheers,
Jared