pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/lang/python



On Mon, 06 Oct 2008, Joerg Sonnenberger wrote:
> Modified Files:
>       pkgsrc/lang/python: extension.mk
> 
> Log Message:
> Add support to derive the Python version from PKGNAME_OLD.

This looks useful, especially if pkg_rolling-replace gets taught
to pass the correct value to "make replace".  But why PKGNAME_OLD
instead of using the OLDNAME variable which is already used by
mk/flavor/pkg/replace.mk)?

Also, could the new code be generalised to cope with the case where
I have a private meta-pkg that attempts to build both py24 and py25
variants of something from the same directory, like this:

        DEPENDS+= py24-foo>0:../../baz/py-foo
        DEPENDS+= py25-foo{,-devel}>0:../../baz/py-foo

Here, I suppose the pattern from before the first ':' in the DEPENDS
line could be used in roughly the same way as your patch uses
PKGNAME_OLD, but being careful to handle wildcards and alternates.

--apb (Alan Barrett)


Home | Main Index | Thread Index | Old Index