Re: CVS commit: pkgsrc/x11/qt4-tools

[David Brownlee <abs%NetBSD.org@localhost>]

On Tue, 3 Jun 2008, Thomas Klausner wrote:

> On Tue, Jun 03, 2008 at 07:41:47AM +0000, David Brownlee wrote:
> > Modified Files:
> >         pkgsrc/x11/qt4-tools: Makefile buildlink3.mk
> >
> > Log Message:
> > qt4-tools includes shared libraries against which at least poppler-qt4
> > links. Remove BUILDLINK_DEPMETHOD.qt4-tools?=build from buildlink3.mk
> > and bump PKGREVISION
>
> But for other packages, it is only a build dependency.
> The solution used for qt3-tools is that packages that link against
> qt3-tools libraries set BUILDLINK_DEPMETHOD.qt3-tools in their
> Makefile; for consistency, I think we should do the same here
> (i.e. revert this change and set BUILDLINK_DEPMETHOD.qt4-tools in
> poppler-qt4's Makefile).

        Makes perfect sense - thanks. Change reverted and poppler-qt4
        updated to set
 BUILDLINK_DEPMETHOD.qt4-tools?=full.

--
                David/absolute       -- www.NetBSD.org: No hype required --