Subject: Re: CVS commit: pkgsrc/net/coda
To: Roland Illig <rillig@NetBSD.org>
From: Alistair Crooks <agc@pkgsrc.org>
List: pkgsrc-changes
Date: 12/01/2007 11:10:22
On Sat, Dec 01, 2007 at 10:11:53AM +0100, Roland Illig wrote:
> Bernd Ernesti wrote:
> >On Fri, Nov 30, 2007 at 11:55:40PM +0000, Roland Illig wrote:
> >>Module Name:	pkgsrc
> >>Committed By:	rillig
> >>Date:		Fri Nov 30 23:55:40 UTC 2007
> >>
> >>Modified Files:
> >>	pkgsrc/net/coda: distinfo
> >>Added Files:
> >>	pkgsrc/net/coda/patches: patch-ac
> >>
> >>Log Message:
> >>Added a patch for NetBSD >= 4.99.
> >
> >Hmm, really .0 or didn't you mean .24?
> >If thats because of 1.55 of coda_vfsops.c.
> 
> I don't know at which version the change was introduced, and I just 
> wanted it to work with my system, which is at 4.99.30. Feel free to 
> change it to whatever is more appropriate.

Ummm, no, that's not how it works. The person who makes the change
needs to do it properly.

cvs log of coda_vfsops.c tells me:

	revision 1.55
	date: 2007/07/12 19:38:26;  author: dsl;  state: Exp;  lines: +12 -4
	Update coda for VFS_MOUNT() change

and cvs log of sys/param.h tells me:

	revision 1.267
	date: 2007/07/17 11:27:11;  author: pooka;  state: Exp;  lines: +2 -2
	branches:  1.267.2;
	4.99.24 - set_statvfs_info() vfsname parameter
	----------------------------
	revision 1.266
	date: 2007/07/09 21:13:56;  author: ad;  state: Exp;  lines: +2 -2
	4.99.23 - partial merge from the vmlocking branch.

So I suspect that the value to go with here is 4.99.23.

Regards,
Alistair