Subject: Re: CVS commit: pkgsrc/net/Transmission
To: Tobias Nygren <tnn@netbsd.org>
From: OBATA Akio <obache@netbsd.org>
List: pkgsrc-changes
Date: 08/11/2007 21:29:25
On Sat, 11 Aug 2007 18:55:41 +0900, Tobias Nygren <tnn@NetBSD.org> wrote=
:

> On Sat, 11 Aug 2007 18:28:52 +0900
> "OBATA Akio" <obache@netbsd.org> wrote:
>
>> On Sat, 11 Aug 2007 18:18:48 +0900, Tobias Nygren <tnn@netbsd.org> wr=
ote:
>>
>> >
>> > Module Name:	pkgsrc
>> > Committed By:	tnn
>> > Date:		Sat Aug 11 09:18:48 UTC 2007
>> >
>> > Modified Files:
>> > 	pkgsrc/net/Transmission: Makefile
>> >
>> > Log Message:
>> > This package uses libevent, and the builtin version in netbsd-{2,3}=
 is too
>> > old. Use libevent from pkgsrc. Should fix PR pkg/36771 from Gilles =
Gravier.
>> > PKGREVISION++
>> >
>> >
>> > To generate a diff of this commit:
>> > cvs rdiff -r1.5 -r1.6 pkgsrc/net/Transmission/Makefile
>> >
>> > Please note that diffs are not public domain; they are subject to t=
he
>> > copyright notices on the relevant files.
>>
>> Why USE_BUILTIN.libevent=3DNO ?
>> If devel/libevent/buitin.mk can't detect correct builtin version,
>> it should be fixed.
>
> I was under the impression that it doesn't work for builtin packages.
> At least plenty of comments in other packages suggest that.
> For example net/tor/Makefile:
>
> BUILDLINK_API_DEPENDS.libevent+=3D libevent>=3D1.1a
> # XXX the pkgsrc libevent builtin.mk does not detect the version of a =
builtin
> # libevent, so we need to force use of the pkgsrc one
> USE_BUILTIN.libevent=3D   no
>
> If this is indeed wrong I agree it should be fixed, but in that case
> it should be fixed for all packages using libevent.

Package net/tor is bad example.
This package was marked as USE_BUILTIN.libevent=3Dno before I implemente=
d builtin detection.
And I can't fix dependency because I don't know why this package require=
 version 1.1a,
libevent have no functionally change from version 1.0d to 1.1b, i.e. rea=
lly need 1.1a?

-- =

"Of course I love NetBSD":-)
OBATA Akio / obache@NetBSD.org