Subject: Re: CVS commit: pkgsrc/mk
To: Alistair Crooks <agc@pkgsrc.org>
From: Tobias Nygren <tnn@NetBSD.org>
List: pkgsrc-changes
Date: 04/17/2007 22:48:03
Alistair Crooks wrote:
> On Tue, Apr 17, 2007 at 10:48:30AM +0000, Tobias Nygren wrote:
>   
>> Module Name:	pkgsrc
>> Committed By:	tnn
>> Date:		Tue Apr 17 10:48:29 UTC 2007
>>
>> Modified Files:
>> 	pkgsrc/mk: bsd.prefs.mk
>>
>> Log Message:
>> Save a fork() by not invoking the 'tr' utility.
>> XXX: the OS_VERSION stuff could use a similar cleanup, replacing
>> tr A-Z a-z occurences with the make :tl modifier.
>>     
>
> Can we assume that all versions of make/bmake that are used will
> support the :tl modifier? (I don't know the answer, just stating
> why tr(1) was used previously).
>
> Regards,
> Alistair
>   

Not sure, hence the XXX in the comment. We do have a version check and
requirements on the pkgtools used. Even if not now, surely at some point
in the future we'll want to be able to use "new" make features.
NetBSD 1.6 and up have a make with the lowercase feature.

(The assumption that the user has a working tr(1) in his $PATH is a real
eyesore even if it has proved to work fine.)

@ rillig, joerg: thanks for correcting my commit.

-Tobias