Subject: Re: CVS commit: pkgsrc/devel/libgphoto2
To: Bernd Ernesti <veego@NetBSD.org>
From: Stephen Borrill <sborrill@NetBSD.org>
List: pkgsrc-changes
Date: 03/24/2007 08:46:10
Bernd Ernesti wrote:
> Hmmm,
>
> I also tracked it down to
>
> https://sourceforge.net/tracker/?func=detail&atid=108874&aid=1648398&group_id=8874
>
> which uses a different patch which was allready commited to the libgphoto2
> source code.
Yes, I'd looked at using UCS-2LE and BE.
However, I'd spotted at byteorder is always set to LE (as shown in this
patch too):
camera->pl->params.byteorder = PTP_DL_LE;
+ if (camera->pl->params.byteorder == PTP_DL_LE) {
+ camloc = "UCS-2LE";
+ } else {
+ camloc = "UCS-2BE";
+ }
byteorder isn't altered anywhere else that I can see.
> It would be better to use rev 9964 (there were some further commits, but they
> were backout out).
>
> See attached patch (which fixed two files in one patch). I didn't had the time
> to commit this patch.
pkgsrc is frozen now for 2007Q1 anyway; I'd need to get permission to commit
this (plus I'd like to test it on a BE and LE machine first).
Leave this with me.
Thanks,
--
Stephen