Subject: Re: CVS commit: pkgsrc/net/samba
To: None <tv@netbsd.org>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 10/17/2006 21:18:40
Todd Vierling wrote:
> Module Name:	pkgsrc
> Committed By:	tv
> Date:		Tue Oct 17 11:29:36 UTC 2006
> 
> Modified Files:
> 	pkgsrc/net/samba: Makefile
> 
> Log Message:
> Don't use .for with on-demand expanded variables that depend on an
> extracted source tree.  That expands them at parse time, and without the
> source tree, causes all kinds of headaches in bmake, e.g.
> 
> /usr/bin/awk: can't open file /export/SRC/netbsd/pkgsrc/net/samba/work.i386/samba-3.0.22/source/Makefile.in source line number 1
> make: "/usr/bin/awk -F= '/^LIBMSRPC_MAJOR/ { print $2; }'	 /export/SRC/netbsd/pkgsrc/net/samba/work.i386/samba-3.0.22/source/Makefile.in" returned non-zero status
> 
> Rewrite to use a shell loop.

I'm sorry that I broke the samba package. I had tested the change, but 
it seems I only did that while the distfiles were extracted.

Thank you, Todd, for fixing it.

Roland