Subject: Re: CVS commit: pkgsrc
To: Johnny C. Lam <jlam@NetBSD.org>
From: Alistair Crooks <agc@pkgsrc.org>
List: pkgsrc-changes
Date: 07/20/2006 15:31:58
On Thu, Jul 20, 2006 at 01:48:15PM +0000, Johnny C. Lam wrote:
>
> Module Name: pkgsrc
> Committed By: jlam
> Date: Thu Jul 20 13:48:15 UTC 2006
>
> Modified Files:
> pkgsrc/security/amavisd-new: Makefile
> pkgsrc/textproc/ruby-nqxml: Makefile
> pkgsrc/textproc/ruby-xmlscan: Makefile
>
> Log Message:
> REPLACE_INTERPRETER occurs as part of the configure step, so don't set
> NO_CONFIGURE.
Perhaps, to be on the safe side, we should check whether
REPLACE_INTERPRETER is set, as well as the value/setting of
NO_CONFIGURE?
The more drastic step is to say
.if defined(REPLACE_INTERPRETER)
.undef NO_CONFIGURE
.endif
I think we should err on the side of POLA - there may well be people
out there with custom package Makefiles not under our control.
Regards,
Alistair