Module Name:	pkgsrc
Committed By:	rillig
Date:		Sun Jul  2 09:47:18 UTC 2006

Modified Files:
	pkgsrc/pkgtools/pkglint: Makefile TODO
	pkgsrc/pkgtools/pkglint/files: deprecated.map makevars.map pkglint.0
	    pkglint.1 pkglint.pl
	pkgsrc/pkgtools/pkglint/files/doc: chap.types.xml

Log Message:
Updated pkglint to 4.66.

This change includes all the things I thought of during the freeze of
2006Q2.

Some variables have disappeared from pkgsrc without notice. Marked them
deprecated to help the package authors at least a bit.

Renamed some ACL abbreviations in makevars.map and adjusted the variable
definitions.

Added the command line options -Dtrace, -Dunchecked and -Dunused.

Some variables may contain unexpected white-space and therefore should
not be used in .for loops.

The -Dmisc option replaces the --verbose option (and the log_info
subroutine), which does not exist any longer. This eliminates all
instances of "OK:" from the output, which I didn't like from the
beginning. The -Dmisc option also takes over many warnings that have
been issued by --debug before.

Improved the check for absolute pathnames. Especially, everything that
follows ${DESTDIR} or $(DESTDIR) in a Makefile is considered an absolute
pathname. This reveals many wrong uses of DESTDIR (as defined by the GNU
coding standards), for example $(DESTDIR)/$(prefix), which should be
$(DESTDIR)$(prefix) instead.

Almost every use of a make(1) variable is checked for spelling mistakes.
Before, only the definitions of variables have been checked.

Restricted the use of variables to specific files, which are defined in
makevars.map. This catches especially buildlink3.mk files with
unexpected side effects.

In shell commands, neither "echo" nor "echo -n" or "${ECHO} -n" should
be used. Since the INSTALL_*_DIR commands can only handle one directory
at a time, suggest to use INSTALLATION_DIRS instead.

Greatly improved the checks for dependency specifications, especially to
find foo-*, which should rather be foo-[0-9]*.

Fixed the incorrect handling of LICENSE_FILE (now using $line->text
instead of $line).

Improved the wording of the "plural names" warnings, so that for known
variables it is "The += operator should only be used with lists." now.

In buildlink3.mk files the uppercase and lowercase names of the package
should correspond with the package name. This catches many
copy-and-paste mistakes. Fixed many null pointer exceptions as well. In
addition, every buildlink3.mk file needs a definition of
BUILDLINK_API_DEPENDS.

In patch files, absolute pathnames and unportable macro names are
checked not only in added lines, but also in the context lines.

In the pkgsrc root directory and the category directories, the Makefiles
are checked like every other Makefile, too.

Fixed the place where the global variables for the package context are
defined and later undefined.

Variables that are mentioned in EVAL_PREFIX may be used in the current
file and are not flagged as "used but not defined".

When parsing shell words in Makefiles, recognize $<, $@, $^ and $/.
(The latter is used extensively by openoffice to represent a directory
separator.)

Fixed some minor bugs:
* $makevar had been defined unintentionally by using the -> operator.


To generate a diff of this commit:
cvs rdiff -r1.344 -r1.345 pkgsrc/pkgtools/pkglint/Makefile
cvs rdiff -r1.49 -r1.50 pkgsrc/pkgtools/pkglint/TODO
cvs rdiff -r1.39 -r1.40 pkgsrc/pkgtools/pkglint/files/deprecated.map
cvs rdiff -r1.121 -r1.122 pkgsrc/pkgtools/pkglint/files/makevars.map
cvs rdiff -r1.30 -r1.31 pkgsrc/pkgtools/pkglint/files/pkglint.0
cvs rdiff -r1.40 -r1.41 pkgsrc/pkgtools/pkglint/files/pkglint.1
cvs rdiff -r1.633 -r1.634 pkgsrc/pkgtools/pkglint/files/pkglint.pl
cvs rdiff -r1.12 -r1.13 pkgsrc/pkgtools/pkglint/files/doc/chap.types.xml

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.