Subject: Re: CVS commit: pkgsrc/mk/check
To: None <jlam@netbsd.org>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 06/15/2006 07:08:39
Johnny C. Lam wrote:
> Module Name:	pkgsrc
> Committed By:	jlam
> Date:		Mon Jun 12 03:42:02 UTC 2006
> 
> Modified Files:
> 	pkgsrc/mk/check: check-interpreter.mk
> 
> Log Message:
> Be more consistent about how we're emitting errors and warnings.

Since the ">> ${ERROR_DIR}/${.TARGET}" code will appear in every "echo" 
command, what about defining

DELAYED_ERROR_MSG?=    ${ECHO} >> ${ERROR_DIR}/${.TARGET}

I really don't like that in the current code both warnings and error 
messages start with a simple ${ECHO}, and that the part that 
distinguishes the two commands to the right of column 80.

Roland