Johnny C. Lam wrote:
> Module Name:	pkgsrc
> Committed By:	jlam
> Date:		Fri Jun  9 13:59:08 UTC 2006
> 
> Modified Files:
> 	pkgsrc/mk: bsd.pkg.mk compiler.mk
> 	pkgsrc/mk/check: check-files.mk check-interpreter.mk check-shlibs.mk
> 	    check-wrkref.mk
> 	pkgsrc/mk/depends: depends.mk
> 	pkgsrc/mk/extract: extract.mk
> 	pkgsrc/mk/flavor/pkg: install.mk
> 	pkgsrc/mk/install: install.mk
> 	pkgsrc/mk/package: package.mk
> 	pkgsrc/mk/patch: patch.mk
> 	pkgsrc/mk/tools: bsd.tools.mk
> Added Files:
> 	pkgsrc/mk: bsd.pkg.error.mk
> 
> Log Message:
> Introduce the capability to gather all the warnings and errors that
> are generated for a target and output them all at once at the conclusion
> of the target's invocation.  The implementation is in bsd.pkg.error.mk,
> which defines a macro target "error-check" that will print out any
> non-empty warning and error files in ${WARNING_DIR} and ${ERROR_DIR}
> and exit appropriately if there were errors.

Now the code looks pretty weird, at least in 
mk/check/check-interpreter.mk. The command ${WARNING_MSG} is still used, 
but instead of ${ERROR_MSG}, you are using a simple ${ECHO}, which in my 
opinion doesn't express clearly enough what the code wants to say.

Roland