Subject: Re: CVS commit: pkgsrc/multimedia/x264-devel
To: None <pkgsrc-changes@NetBSD.org, joerg@NetBSD.org>
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
List: pkgsrc-changes
Date: 02/23/2006 12:09:45
> From: Joerg Sonnenberger <joerg@NetBSD.org>
> Subject: CVS commit: pkgsrc/multimedia/x264-devel
> 
> 
> Module Name:	pkgsrc
> Committed By:	joerg
> Date:		Tue Feb 21 23:20:38 UTC 2006
> 
> Modified Files:
> 	pkgsrc/multimedia/x264-devel: Makefile
> 
> Log Message:
> Add build time dependency on nasm / yasm for i386 and amd64.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.1.1.1 -r1.2 pkgsrc/multimedia/x264-devel/Makefile
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.


I would like the following:

.if ${MACHINE_ARCH} == "i386"
.  if ${ABI} != "64"
BUILD_DEPENDS+=       nasm>=0.98.34:../../devel/nasm
.  else
BUILD_DEPENDS+=       yasm>=0.4.0:../../devel/yasm
.  endif
.elif ${MACHINE_ARCH} == "x86_64"
BUILD_DEPENDS+=       yasm>=0.4.0:../../devel/yasm
.endif

because 'generic' solaris MACHINE_ARCH is i386 and don't take care of ABI.
Second, x86_64 Solaris MACHINE_ARCH does not exist in pkgsrc.
maybe it is also true for other system with bi-arch (32/64) ABI.

Hope it is understandable
Sorry for bad english
Gilles