Subject: CVS commit: pkgsrc/devel/p5-IO-Tty
To: None <pkgsrc-changes@NetBSD.org>
From: Klaus Heinz <heinz@netbsd.org>
List: pkgsrc-changes
Date: 02/19/2006 01:28:53
Module Name:	pkgsrc
Committed By:	heinz
Date:		Sun Feb 19 01:28:53 UTC 2006

Modified Files:
	pkgsrc/devel/p5-IO-Tty: Makefile distinfo
Added Files:
	pkgsrc/devel/p5-IO-Tty/patches: patch-ab

Log Message:
IO::Tty was broken on NetBSD >= 3.0.
patch-ab is only an unintrusive short-term fix, discussion with the authors
how to fix it correctly has started.

NetBSD >= 3.0 supports grantpt() but it invalidates the slave
FD (see grantpt(3) on NetBSD) obtained through openpty() so we discard
the (now invalid) descriptor for the slave tty. This causes Tty.xs to open
the slave tty again.

The issue should be really fixed by using posix_openpt() instead of
openpty(). The functions posix_openpt(), grantpt(), unlockpt()
and ptsname() belong together and should be used ahead of
all the other ways to create the master and slave tty, not just
on NetBSD. See also
http://www.opengroup.org/onlinepubs/009695399/functions/posix_openpt.html


To generate a diff of this commit:
cvs rdiff -r1.17 -r1.18 pkgsrc/devel/p5-IO-Tty/Makefile
cvs rdiff -r1.6 -r1.7 pkgsrc/devel/p5-IO-Tty/distinfo
cvs rdiff -r0 -r1.1 pkgsrc/devel/p5-IO-Tty/patches/patch-ab

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.