Subject: Re: CVS commit: pkgsrc
To: None <jlam@netbsd.org>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 01/21/2006 11:29:11
Johnny C. Lam wrote:
> Log Message:
> Rename the following variables to reduce the number that we need to track:
>
> EXTRACT_CMD_OPTS.bin -> EXTRACT_OPTS_BIN
> EXTRACT_CMD_OPTS.lha -> EXTRACT_OPTS_LHA
> EXTRACT_CMD_OPTS.rar -> EXTRACT_OPTS_RAR
> EXTRACT_CMD_OPTS.tar -> EXTRACT_OPTS_TAR
> EXTRACT_CMD_OPTS.tar.Z -> EXTRACT_OPTS_TAR
> EXTRACT_CMD_OPTS.tar.bz2 -> EXTRACT_OPTS_TAR
> EXTRACT_CMD_OPTS.tar.gz -> EXTRACT_OPTS_TAR
> EXTRACT_CMD_OPTS.tbz -> EXTRACT_OPTS_TAR
> EXTRACT_CMD_OPTS.tbz2 -> EXTRACT_OPTS_TAR
> EXTRACT_CMD_OPTS.tgz -> EXTRACT_OPTS_TAR
> EXTRACT_CMD_OPTS.zip -> EXTRACT_OPTS_ZIP
> EXTRACT_CMD_OPTS.zoo -> EXTRACT_OPTS_ZOO
> EXTRACT_CMD_OPTS_tar.gz -> EXTRACT_OPTS_TAR
This naming scheme conflicts with one that I just got used to, namely
that the last component of a variable name often marks the type of the
variable (like SUBST_FILES, EGDIR, APACHE_USER, DISTFILES). Another
convention is to use a "." instead of a "_" to define parameterized
variables. Up to now, the only serious breakage of that rule have been
the SITES_${file} variables.
What about the name EXTRACT_OPTS.BIN, which would preserve the above
naming conventions, while, by using an uppercase "BIN" instead of "bin",
expressing that the variable EXTRACT_OPTS is not parameterized with a
filename suffix, but something else.
Roland