Subject: Re: CVS commit: pkgsrc/multimedia/mplayer-share
To: Daniel Carosone <dan@geek.com.au>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 11/11/2005 08:49:39
On Thu, Nov 10, 2005 at 11:30:25PM +0100, Quentin Garnier wrote:
>>On Sat, Nov 05, 2005 at 05:21:02PM +0000, Roland Illig wrote:
>>
>>>Module Name: pkgsrc
>>>Committed By: rillig
>>>Date: Sat Nov 5 17:21:02 UTC 2005
>>>
>>>Modified Files:
>>> pkgsrc/multimedia/mplayer-share: options.mk
>>>
>>>Log Message:
>>>Replaced an overly complex expression with the roughly equivalent
>>>${PKGBASE}.
>>
>>This is broken. PKGBASE is not defined until after bsd.options.mk is
>>processed. Therefore, options processing in mplayer packages simply
>>doesn't work.
Many thanks for clarifying this. I have reverted my changes and added a
big note to prevent others from reintroducing this bug.
Roland