Subject: Re: CVS commit: pkgsrc/www
To: Johnny C. Lam <jlam@NetBSD.org>
From: Krister Walfridsson <cato@df.lth.se>
List: pkgsrc-changes
Date: 09/17/2005 14:26:18
On Sat, 17 Sep 2005, Johnny C. Lam wrote:

>
> Module Name:	pkgsrc
> Committed By:	jlam
> Date:		Sat Sep 17 02:35:20 UTC 2005
>
> Modified Files:
> 	pkgsrc/www/firefox: Makefile Makefile-firefox.common PLIST
> 	pkgsrc/www/firefox-gtk1: Makefile PLIST
> 	pkgsrc/www/mozilla: Makefile Makefile.common PLIST
> 	pkgsrc/www/mozilla-gtk2: Makefile PLIST
> 	pkgsrc/www/mozilla/files: moz-install
> Added Files:
> 	pkgsrc/www/firefox: INSTALL
> 	pkgsrc/www/mozilla: INSTALL
>
> Log Message:
> For the native firefox and mozilla packages, move the module/extension
> registration out of the installation step and into the INSTALL script.
> Also, remove the registration commands from the PLIST as well.  Putting
> them into the INSTALL script allows for the same commands to be run
> in the same way, so that there are fewer differences between installing
> from source and installing from a binary package.  Also, this makes
> these packages pass CHECK_FILES=yes.  Bump the PKGREVISION of firefox,
> firefox-gtk1, mozilla, and mozilla-gtk2.
>
> Also, include bsd.pkg.mk from the package Makefiles, not from within
> Makefile.common.  This is a style issue and allows for appending to
> variables originally defined in Makefile.common from the package
> Makefile.

You need to updated mail/thunderbird and mail/thunderbird-gtk1 too since 
they includes www/mozilla/Makefile.common (and your change to that 
file makes them not include mk/bsd.pkg.mk...)

    /Krister