Subject: Re: CVS commit: pkgsrc/audio/abcde
To: Roland Illig <rillig@NetBSD.org>
From: Alistair Crooks <agc@pkgsrc.org>
List: pkgsrc-changes
Date: 05/31/2005 23:17:46
On Tue, May 31, 2005 at 09:40:37PM +0000, Roland Illig wrote:
> 
> Module Name:	pkgsrc
> Committed By:	rillig
> Date:		Tue May 31 21:40:37 UTC 2005
> 
> Modified Files:
> 	pkgsrc/audio/abcde: Makefile
> 
> Log Message:
> Changed value of NO_BUILD from #defined to yes.

Whilst it may make sense in the general scheme of things, I really
don't like having to set a "NO_wibble" variable to have the value
"yes".  I am obviously logically-challenged, because "NO_BUILD=yes"
does not parse easily for me, and I have to think about it a fair
amount before I can understand what it's doing.

My suggestion is to change the sequence so it's much more positive:

	DO_BUILD?= yes

with deviations from the norm looking like:

	DO_BUILD= no


Regards,
Alistair