On Mon, May 23, 2005 at 07:57:02AM +0000, Roland Illig wrote:
> 
> Module Name:	pkgsrc
> Committed By:	rillig
> Date:		Mon May 23 07:57:02 UTC 2005
> 
> Modified Files:
> 	pkgsrc/mk: bsd.pkg.subdir.mk
> 
> Log Message:
> Fixed quoting in show-comment.

I think this got munged a bit:

*** 172,179 ****
  .endif
  
  show-comment:
!       @if [ "${COMMENT}" ]; then                                      \
!               ${ECHO} "${COMMENT:Q}";                                 \
        elif [ -f COMMENT ] ; then                                      \
                ${CAT} COMMENT;                                         \
        else                                                            \
--- 172,179 ----
  .endif
  
  show-comment:
!       @if [ -z ${COMMENT:Q}"" ]; then                                 \
!               ${ECHO} ${COMMENT:Q};                                   \
        elif [ -f COMMENT ] ; then                                      \
                ${CAT} COMMENT;                                         \
        else                                                            \

whereas before the comment would be displayed if it was non-zero
length, now it seems that it will only be echoed if it is zero-length
(if I'm reading the shell commands correctly, what you've added is an
unusual construct to me).

Can you explain your new construct a bit better for me, please?

Thanks,
Alistair