Subject: Re: CVS commit: pkgsrc/sysutils/nautilus-cd-burner
To: None <M.Drochner@fz-juelich.de>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: pkgsrc-changes
Date: 04/25/2005 20:41:20
On Mon, 2005-04-25 at 20:23 +0200, Matthias Drochner wrote:
> jmmv84@gmail.com said:
> > This change is incorrect. Just set USE_MSGFMT_PLURALS=YES together
> > with BUILD_USES_MSGFMT=YES and all should be fine.
> >
> > (Otherwise, the user ends up with multiple versions of gettext
> > installed and if they both get loaded at the same time... interesting
> > problems will arise.)
>
> My change is about the "msgfmt" tool, not about libintl.
> We still get the system libintl:
> $ ldd /usr/pkg/bin/nautilus-cd-burner |grep intl
> -lintl.0 => /usr/lib/libintl.so.0
IC (I didn't check how you did it). But anyway, I still consider the
change to be incorrect. First of all, it's assuming that gettext will
always be too old, no matter which system are you using pkgsrc on.
Then, it's using LOCALBASE, when maybe gettext is not there (even if
it's installed from pkgsrc). And, at last, it's not using the
functionality we already have in pkgsrc to handle the msgid_plural
problems (USE_MSGFMT_PLURALS=YES, as I said above, which makes it work
without any other changes). This should be changed.
Cheers,
--
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/