On Sat,  8 Jan 2005 19:40:37 +0000 (UTC)
"Perry E. Metzger" <perry@netbsd.org> wrote:
> 
> Module Name:	pkgsrc
> Committed By:	perry
> Date:		Sat Jan  8 19:40:37 UTC 2005
> 
> Modified Files:
> 	pkgsrc/devel/py-idle: Makefile
> 
> Log Message:
> Make idle work with python 24pth

While not specifically an issue with this update, I wonder about the
following line in the Makefile:

PYTHON_VERSIONS_ACCEPTED=     20 20pth 21 21pth 22 22pth 23pth 24pth

Since the order determines which one will be accepted when multiple
versions are installed, shouldn't we be change this to prefer the latest
version over the oldest?  The above will use Python 2.0 unthreaded if it
is installed for any reason even if the user is using 2.4 threaded for
everything else.  I think we should change lines like the above to the
following:

PYTHON_VERSIONS_ACCEPTED=     24pth 24 23pth 23 22pth 22 21pth 21 20pth
20

> Note that this probably should be done more cleanly but I'm not clear
> on how that would be done best.

For one thing we should probably remove the PYTHON_VERSIONS_ACCEPTED
line altogether since the above is the default anyway and change the .if
to test for < 2.3 instead of each of 2.3 and 2.4.  That would remove the
need to change it when the next version of Python is released.  Would
you like me to give it a shot?

-- 
D'Arcy J.M. Cain <darcy@NetBSD.org>
http://www.NetBSD.org/