Subject: CVS commit: pkgsrc
To: None <pkgsrc-changes@NetBSD.org>
From: Jim Wise <jwise@netbsd.org>
List: pkgsrc-changes
Date: 06/15/2004 16:39:12
Module Name:	pkgsrc
Committed By:	jwise
Date:		Tue Jun 15 16:39:12 UTC 2004

Modified Files:
	pkgsrc/lang/tcl: Makefile buildlink3.mk
	pkgsrc/x11/tk: Makefile buildlink3.mk

Log Message:
Reverse previous commit (disabling thread-safety), which was poorly though
through, unacceptably breaks threaded apps, and was made without consulting
the package's maintainer.

To quote my mail to packages@:

I am reversing this change.

With this change, tcl is _not_ usable in threaded apps, while without
this change, tcl is perfectly usable in non-threaded apps.

The fix for a package which is incorrectly written is not to break the
package it depends on, but do your job correctly when writing the
package.

With buildlink3, this is mind-numbingly easy to do.

That you neither contacted the maintainer of this package, nor did the
buildlink and dependent package changes which your change requires shows
that you have not really thought this through.

So, as I said, I am reversing this change.  Fix your own package, don't
break others.


To generate a diff of this commit:
cvs rdiff -r1.33 -r1.34 pkgsrc/lang/tcl/Makefile
cvs rdiff -r1.10 -r1.11 pkgsrc/lang/tcl/buildlink3.mk
cvs rdiff -r1.34 -r1.35 pkgsrc/x11/tk/Makefile
cvs rdiff -r1.11 -r1.12 pkgsrc/x11/tk/buildlink3.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.