Subject: Re: CVS commit: pkgsrc/mk
To: None <tech-pkg@NetBSD.org>
From: Alistair Crooks <agc@pkgsrc.org>
List: pkgsrc-changes
Date: 05/08/2004 15:03:13
On Sat, May 08, 2004 at 02:13:00AM +0000, Jeremy C. Reed wrote:
>
> Module Name: pkgsrc
> Committed By: reed
> Date: Sat May 8 02:13:00 UTC 2004
>
> Modified Files:
> pkgsrc/mk: bsd.pkg.mk
>
> Log Message:
> If using GNU_CONFIGURE then set --infodir to ${PREFIX}/${INFO_DIR}.
> I have used this successfully to install over 300 info files
> using INFO_DIR=share/info.
>
> Also add new variable called NO_CONFIGURE_INFODIR (as suggested
> by Greg Woods) because some autoconf-style configure scripts
> don't know --infodir. (The alternative is to use HAS_CONFIGURE
> and add the needed CONFIGURE_ARGS.)
In general, I find it clearer to stay away from definitions which
have NO_ in front of them. I may be getting obtuse in my old age,
but "NO_WIBBLE=yes" confuses me no end.
I'd have preferred it to be:
CONFIGURE_HAS_INFODIR?= yes
and in the few exceptional Makefiles, use
CONFIGURE_HAS_INFODIR= no
Regards,
Alistair