Subject: Re: CVS commit: pkgsrc/security/openssh+gssapi
To: James Chacon <jmc@netbsd.org>
From: Jim Wise <jwise@draga.com>
List: pkgsrc-changes
Date: 08/01/2003 19:17:44
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Oh, I agree with setting it on -- I just think the package should skip
rather than fail to link in the case where kerberos is not available.
I'll look into it...

On Fri, 1 Aug 2003, James Chacon wrote:

>I would say default it to on then (set it via ?= rather than = like I did).
>
>James
>
>>
>>-----BEGIN PGP SIGNED MESSAGE-----
>>Hash: SHA1
>>
>>On Fri, 1 Aug 2003, James Chacon wrote:
>>
>>>If you don't want kerberos why would you build this package in the first
>>>place?
>>
>>A bulk build on a platform without kerberos (or without pkgsrc support
>>for kerberos) comes immediately to mind -- and setting PKG_SKIP_REASON
>>if kerberos is not present deals with that case just fine.
>>
>>If kerberos is present, I agree that setting KERBEROS= if it is not set
>>is perfectly reasonable within this package for the reasons you mention
>>below.
>>
>>
>>>It's specifically the kerb patches in here folks want so obviously that
>>>kinda implies the need to define it all correctly.
>>>
>>>(and for a bulk build I really shouldn't have to enable the package per se. it
>>>should just build).
>>>
>>>James
>>>
>>>>
>>>>-----BEGIN PGP SIGNED MESSAGE-----
>>>>Hash: SHA1
>>>>
>>>>On Fri, 1 Aug 2003, James Chacon wrote:
>>>>
>>>>>
>>>>>Module Name:	pkgsrc
>>>>>Committed By:	jmc
>>>>>Date:		Fri Aug  1 03:21:03 UTC 2003
>>>>>
>>>>>Modified Files:
>>>>>	pkgsrc/security/openssh+gssapi: Makefile
>>>>>
>>>>>Log Message:
>>>>>This needs to define KERBEROS or the section which adds the right libraries
>>>>>never gets included and nothing links.
>>>>>
>>>>
>>>>That's a good question -- normally, this package should build with
>>>>krb support if KERBEROS is defined, and without it if it isn't (though I
>>>>agree that the latter case was broken).
>>>>
>>>>OTOH, I agree that it doesn't make any sense to build this package
>>>>without KERBEROS support.
>>>>
>>>>Perhaps a PKG_SKIP_REASON setting if kerberos is not present would make
>>>>sense?
>>>>
>>>>Thanks,
>>>>- --
>>>>				Jim Wise
>>>>				jwise@draga.com
>>>>-----BEGIN PGP SIGNATURE-----
>>>>Version: GnuPG v1.2.2 (NetBSD)
>>>>
>>>>iD8DBQE/KtHvlGcH240chEIRAlq1AKCsD1V7HeqIYKeWcLSgSktF5WSMYACfdX2p
>>>>R+4omJ1v2Y6/cctj3neHKNc=
>>>>=Lz4f
>>>>-----END PGP SIGNATURE-----
>>>>
>>>>
>>>>
>>>
>>
>>- --
>>				Jim Wise
>>				jwise@draga.com
>>-----BEGIN PGP SIGNATURE-----
>>Version: GnuPG v1.2.2 (NetBSD)
>>
>>iD8DBQE/KtlrlGcH240chEIRAkYvAJ421l61GYyH5rG1DBnbj1iSNK2lPwCfU2nD
>>TOeHjBy805AnRA5gArdINkM=
>>=Z7tZ
>>-----END PGP SIGNATURE-----
>>
>>
>>
>

- -- 
				Jim Wise
				jwise@draga.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (NetBSD)

iD8DBQE/KvUdlGcH240chEIRAsRXAJ4qAQiZCiBdJV7KjD6dpDLxNcBVKQCdHBTY
8nUpg8U0yrPj/xGYhVdWHaM=
=M9ia
-----END PGP SIGNATURE-----