On Tue, Jul 22, 2003 at 02:05:48PM +0000, Jim Wise wrote:

> Modified Files:
> 	pkgsrc/textproc/sablotron: Makefile
> 
> Log Message:
> Don't explicitly pull in -liconv -- if we need it, the libiconv buildlink glue
> will give it to us, and if we don't this breaks the build.

This change breaks it on NetBSD 1.6, older -current and Solaris.
this reason for adding it is mentioned in the cvs log for Makefile
rev. 1.9. without it, libsablot doesn't get linked against libiconv
and ends up with undefined symbols:

         U libiconv
         U libiconv_close
         U libiconv_open

unsurprisingly, starting apache with sablotron results in:

Syntax error on line 248 of /usr/pkg/etc/httpd/httpd.conf:
Cannot load lib/libsablot.so into server:/usr/pkg/lib/libsablot.so:
Undefined PLT symbol "libiconv_open" (symnum = 866) /usr/pkg/sbin/apachectl start: httpd could not be started

I guess we should add LIBS+=${_BLNK_ICONV_LDFLAGS}, which will
(should?) be empty if we are not using converters/libiconv.

grant.