Subject: Re: CVS commit: pkgsrc/mk
To: Rene Hexel <rh@netbsd.org>
From: Johnny Lam <jlam@jgrind.org>
List: pkgsrc-changes
Date: 04/22/2002 09:39:06
On Mon, Apr 22, 2002 at 09:53:25PM +1000, Rene Hexel wrote:
> On Mon, 2002-04-22 at 12:30, Johnny C. Lam wrote:
>
> > .if ${MACHINE_ENDIAN} == "big"
> > # ...big endian stuff...
> > .elif ${MACHINE_ENDIAN} == "little"
> > # ...little endian stuff...
> > .else
> > BROKEN= "Unknown endianness"
> > .endif
>
> Probably just nitpicking, but what about esoteric endianness like
> PDP_ENDIAN (LSB first in word, MSW first in long)? Do we really need to
> automatically mark everything as BROKEN if pkgsrc doesn't know about a
> certain endianness?
It was just an example of it's usage. The only packages that will be
using MACHINE_ENDIAN are the packages that include "../../mk/endian.mk"
in their Makefiles. I don't know of any packages that check for other
than big- or little-endianness, but additional endian checks are fairly
easy to add to endian.mk. For packages that _do_ work on only big- or
little-endian platforms, then yes, we do want to mark them as broken on
other platforms.
Cheers,
-- Johnny Lam <jlam@jgrind.org>