pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/mk/buildlink3 mk: Remove XXX comment.



details:   https://anonhg.NetBSD.org/pkgsrc/rev/0b3286918768
branches:  trunk
changeset: 388663:0b3286918768
user:      jperkin <jperkin%pkgsrc.org@localhost>
date:      Thu Nov 24 13:59:20 2022 +0000

description:
mk: Remove XXX comment.

The reason why BUILDLINK_FILES_CMD does not use "pkg_info -qL" instead of
"pkg_info -f" is that -qL returns the full path of the files, whereas -f
already strips the prefix, so using -qL would not provide any advantage,
for example we would still need to call sed to remove the prefix.

diffstat:

 mk/buildlink3/bsd.buildlink3.mk |  3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diffs (17 lines):

diff -r 5100008d404d -r 0b3286918768 mk/buildlink3/bsd.buildlink3.mk
--- a/mk/buildlink3/bsd.buildlink3.mk   Thu Nov 24 13:56:14 2022 +0000
+++ b/mk/buildlink3/bsd.buildlink3.mk   Thu Nov 24 13:59:20 2022 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.buildlink3.mk,v 1.255 2022/11/24 13:56:14 jperkin Exp $
+# $NetBSD: bsd.buildlink3.mk,v 1.256 2022/11/24 13:59:20 jperkin Exp $
 #
 # Copyright (c) 2004 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -633,7 +633,6 @@
 
 BUILDLINK_CONTENTS_FILTER.${_pkg_}?=                                   \
        ${EGREP} '(include.*/|\.h$$|\.idl$$|\.pc$$|/lib[^/]*\.[^/]*$$|lib/cmake/|share/cmake/)'
-# XXX: Why not pkg_info -qL?
 BUILDLINK_FILES_CMD.${_pkg_}?=                                         \
        ${_BLNK_PKG_INFO.${_pkg_}} -f ${BUILDLINK_PKGNAME.${_pkg_}} |   \
        ${SED} -n '/File:/s/^[  ]*File:[        ]*//p' |                \



Home | Main Index | Thread Index | Old Index