[pkgsrc/trunk]: pkgsrc/pkgtools/lintpkgsrc/files lintpkgsrc: cleanup: extract...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/c7ff0035372b
branches:  trunk
changeset: 383433:c7ff0035372b
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Aug 19 05:20:27 2022 +0000

description:
lintpkgsrc: cleanup: extract 'make show-vars' into subroutine

diffstat:

 pkgtools/lintpkgsrc/files/lintpkgsrc.pl |  50 +++++++++++++++++---------------
 1 files changed, 27 insertions(+), 23 deletions(-)

diffs (72 lines):

diff -r 999eb991c637 -r c7ff0035372b pkgtools/lintpkgsrc/files/lintpkgsrc.pl
--- a/pkgtools/lintpkgsrc/files/lintpkgsrc.pl   Fri Aug 19 05:06:26 2022 +0000
+++ b/pkgtools/lintpkgsrc/files/lintpkgsrc.pl   Fri Aug 19 05:20:27 2022 +0000
@@ -1,5 +1,5 @@
 #!@PERL5@
-# $NetBSD: lintpkgsrc.pl,v 1.126 2022/08/19 05:06:26 rillig Exp $
+# $NetBSD: lintpkgsrc.pl,v 1.127 2022/08/19 05:20:27 rillig Exp $
 
 # Written by David Brownlee <abs%netbsd.org@localhost>.
 #
@@ -951,6 +951,30 @@
        }
 }
 
+sub make_show_vars($pkgdir) {
+       debug("Running '$conf_make' in '$pkgdir'");
+       my $pid = open3(\*WTR, \*RDR, \*ERR,
+           "cd $pkgdir || exit 1; $conf_make show-vars VARNAMES=PKGNAME");
+       if (!$pid) {
+               warn "$pkgdir: Unable to run make: $!";
+       } else {
+               close(WTR) or die;
+               my @errors = <ERR>;
+               close(ERR) or die;
+               my $makepkgname = <RDR>;
+               close(RDR) or die;
+               wait;
+               chomp @errors;
+               if (@errors) { warn "\n$pkgdir: @errors\n"; }
+
+               if ($makepkgname =~ /(.*)-(\d.*)/) {
+                       return $makepkgname;
+               }
+       }
+
+       undef;
+}
+
 # Parse a pkgsrc package makefile and return the pkgname and set variables
 #
 sub parse_makefile_pkgsrc($file) {
@@ -966,28 +990,8 @@
        $pkgname = $distname unless defined $pkgname;
 
        if (!defined $pkgname || $pkgname =~ /\$/ || $pkgname !~ /(.*)-(\d.*)/) {
-
-               # invoke make here as a last resort
-               my $pkgdir = dirname $file;
-               debug("Running '$conf_make' in '$pkgdir'");
-               my $pid = open3(\*WTR, \*RDR, \*ERR,
-                   "cd $pkgdir || exit 1; $conf_make show-vars VARNAMES=PKGNAME");
-               if (!$pid) {
-                       warn "$file: Unable to run make: $!";
-               } else {
-                       close(WTR) or die;
-                       my @errors = <ERR>;
-                       close(ERR) or die;
-                       my $makepkgname = <RDR>;
-                       close(RDR) or die;
-                       wait;
-                       chomp @errors;
-                       if (@errors) { warn "\n$file: @errors\n"; }
-
-                       if ($makepkgname =~ /(.*)-(\d.*)/) {
-                               $pkgname = $makepkgname;
-                       }
-               }
+               my $makepkgname = make_show_vars(dirname $file);
+               $pkgname = $makepkgname if defined $makepkgname;
        }
 
        defined $pkgname or return ();