[pkgsrc/trunk]: pkgsrc/pkgtools/lintpkgsrc/files lintpkgsrc: enable Perl warn...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/bd795a686e94
branches:  trunk
changeset: 382494:bd795a686e94
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Jul 29 19:00:36 2022 +0000

description:
lintpkgsrc: enable Perl warnings

No functional change.

diffstat:

 pkgtools/lintpkgsrc/files/lintpkgsrc.pl |  16 +++++++++++-----
 1 files changed, 11 insertions(+), 5 deletions(-)

diffs (56 lines):

diff -r 02342349e801 -r bd795a686e94 pkgtools/lintpkgsrc/files/lintpkgsrc.pl
--- a/pkgtools/lintpkgsrc/files/lintpkgsrc.pl   Fri Jul 29 18:36:06 2022 +0000
+++ b/pkgtools/lintpkgsrc/files/lintpkgsrc.pl   Fri Jul 29 19:00:36 2022 +0000
@@ -1,6 +1,6 @@
 #!@PERL5@
 
-# $NetBSD: lintpkgsrc.pl,v 1.22 2022/04/27 22:24:16 rillig Exp $
+# $NetBSD: lintpkgsrc.pl,v 1.23 2022/07/29 19:00:36 rillig Exp $
 
 # Written by David Brownlee <abs%netbsd.org@localhost>.
 #
@@ -13,9 +13,9 @@
 # TODO: Handle fun DEPENDS like avifile-devel with
 #                      {qt2-designer>=2.2.4,qt2-designer-kde>=2.3.1nb1}
 
-$^W = 1;
 use locale;
 use strict;
+use warnings;
 use Getopt::Std;
 use File::Find;
 use File::Basename;
@@ -38,6 +38,12 @@
     %prebuilt_pkgdir_cache,       # To avoid symlink loops in prebuilt_pkgdirs
 );
 
+sub usage_and_exit();
+sub listdir($$);
+sub get_default_makefile_vars();
+sub fail($);
+sub parse_makefile_pkgsrc($);
+
 $ENV{PATH} .=
   ":/bin:/usr/bin:/sbin:/usr/sbin:${conf_prefix}/sbin:${conf_prefix}/bin";
 
@@ -171,7 +177,7 @@
            }
 
        # distfiles downloaded on the current system
-       @tmpdistfiles = listdir("$pkgdistdir");
+       @tmpdistfiles = listdir("$pkgdistdir", undef);
        foreach my $tmppkg (@tmpdistfiles)
            {
            if ($tmppkg ne "pkg-vulnerabilities")
@@ -561,9 +567,9 @@
     $cmp;
 }
 
-sub fail(@) {
+sub fail($) {
 
-    print STDERR @_, "\n";
+    print STDERR shift(), "\n";
     exit(3);
 }