[pkgsrc/trunk]: pkgsrc/sysutils/puppet puppet: Fix up SMF install on SunOS.

[jperkin <jperkin%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/1df0f77d0854
branches:  trunk
changeset: 378073:1df0f77d0854
user:      jperkin <jperkin%pkgsrc.org@localhost>
date:      Thu Apr 28 14:54:53 2022 +0000

description:
puppet: Fix up SMF install on SunOS.

There's no way that this package is working correctly anywhere though, there
are many broken paths.  It needs quite a bit of love, and an update.

diffstat:

 sysutils/puppet/Makefile |  38 +++++++++++++++-----------------------
 sysutils/puppet/PLIST    |   6 +-----
 2 files changed, 16 insertions(+), 28 deletions(-)

diffs (104 lines):

diff -r fee3ab511357 -r 1df0f77d0854 sysutils/puppet/Makefile
--- a/sysutils/puppet/Makefile  Thu Apr 28 13:59:09 2022 +0000
+++ b/sysutils/puppet/Makefile  Thu Apr 28 14:54:53 2022 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.53 2021/12/14 14:47:28 taca Exp $
+# $NetBSD: Makefile,v 1.54 2022/04/28 14:54:53 jperkin Exp $
 
 DISTNAME=              puppet-7.13.1
 CATEGORIES=            sysutils
@@ -27,6 +27,12 @@
 PKG_SYSCONFSUBDIR=     puppet
 RCD_SCRIPTS=           puppetd puppetmasterd
 
+SMF_SRCDIR=            ${WRKSRC}/ext/solaris/smf
+SMF_MANIFEST=          puppet.xml
+SMF_METHODS=           puppet
+SMF_METHOD_SRC.puppet= ${SMF_SRCDIR}/puppet
+SMF_NAME=              puppet
+
 SUBST_CLASSES+=                prefix
 SUBST_STAGE.prefix=    pre-configure
 SUBST_FILES.prefix=    install.rb
@@ -37,8 +43,6 @@
 SUBST_FILES.prefix+=   lib/puppet/face/module/upgrade.rb
 SUBST_FILES.prefix+=   lib/puppet/reference/configuration.rb
 SUBST_FILES.prefix+=   lib/puppet/util/run_mode.rb
-SUBST_FILES.prefix+=   ext/solaris/smf/puppet
-SUBST_FILES.prefix+=   ext/solaris/smf/puppet.xml
 SUBST_FILES.prefix+=   man/man5/puppet.conf.5
 SUBST_FILES.prefix+=   man/man8/puppet-apply.8
 SUBST_FILES.prefix+=   man/man8/puppet-module.8
@@ -46,7 +50,14 @@
 SUBST_FILES.prefix+=   spec/unit/util/run_mode_spec.rb
 SUBST_FILES.prefix+=   spec/unit/util/selinux_spec.rb
 SUBST_SED.prefix=      -e "s|/etc/puppet|${PKG_SYSCONFDIR}|g"
-SUBST_SED.prefix+=     -e "s|/opt/csw/lib|${PREFIX}/lib|g"
+
+SUBST_CLASSES+=                smf
+SUBST_STAGE.smf=       pre-configure
+SUBST_FILES.smf+=      ext/solaris/smf/puppet
+SUBST_FILES.smf+=      ext/solaris/smf/puppet.xml
+SUBST_SED.smf=         -e "s,/etc/puppetlabs/puppet,${PKG_SYSCONFDIR},g"
+SUBST_SED.smf+=                -e "s,/opt/puppetlabs/bin/puppet,${PREFIX}/bin/puppet${RUBY_SUFFIX},g"
+SUBST_SED.smf+=                -e "s,network/puppet,${SMF_PREFIX}/puppet,g"
 
 SUBST_CLASSES+=                sufx
 SUBST_STAGE.sufx=      pre-configure
@@ -73,7 +84,6 @@
 #PKG_GECOS.${PUPPET_USER}=     Puppet configuration management pseudo-user
 
 PLIST_SUBST+=          EGDIR=${EGDIR}
-PLIST_VARS+=           sunos
 
 BUILD_DEFS+=           VARBASE
 INSTALLATION_DIRS+=    ${EGDIR}
@@ -83,14 +93,6 @@
 #PUPPET_GROUP?=                puppet
 #PUPPET_USER?=         puppet
 
-.if ${OPSYS} == "SunOS"
-INSTALLATION_DIRS+=    lib/svc/method ${EGDIR}/svc
-CONF_DIRS+=            ${VARBASE}/svc/manifest
-CONF_FILES+=           ${EGDIR}/svc/puppetd.xml ${VARBASE}/svc/manifest/puppetd.xml
-CONF_FILES+=           ${EGDIR}/svc/puppetmasterd.xml ${VARBASE}/svc/manifest/puppetmasterd.xml
-PLIST.sunos=           yes
-.endif
-
 pre-configure:
        cd ${WRKSRC}/bin && ${CHMOD} ${BINMODE} puppet
 
@@ -106,16 +108,6 @@
 post-install:
        ${INSTALL_DATA} ${WRKSRC}/examples/puppet.conf                  \
                ${DESTDIR}${PREFIX}/${EGDIR}
-.if ${OPSYS} == "SunOS"
-       ${INSTALL_DATA} ${WRKSRC}/ext/solaris/smf/puppetd.xml           \
-               ${DESTDIR}${PREFIX}/${EGDIR}/svc
-       ${INSTALL_DATA} ${WRKSRC}/ext/solaris/smf/puppetmasterd.xml     \
-               ${DESTDIR}${PREFIX}/${EGDIR}/svc
-       ${INSTALL_SCRIPT} ${WRKSRC}/ext/solaris/smf/svc-puppetd         \
-               ${DESTDIR}${PREFIX}/lib/svc/method
-       ${INSTALL_SCRIPT} ${WRKSRC}/ext/solaris/smf/svc-puppetmasterd   \
-               ${DESTDIR}${PREFIX}/lib/svc/method
-.endif
 
 .include "../../lang/ruby/gem.mk"
 .include "../../mk/bsd.pkg.mk"
diff -r fee3ab511357 -r 1df0f77d0854 sysutils/puppet/PLIST
--- a/sysutils/puppet/PLIST     Thu Apr 28 13:59:09 2022 +0000
+++ b/sysutils/puppet/PLIST     Thu Apr 28 14:54:53 2022 +0000
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.33 2021/12/14 14:47:28 taca Exp $
+@comment $NetBSD: PLIST,v 1.34 2022/04/28 14:54:53 jperkin Exp $
 bin/puppet${RUBY_SUFFIX}
 ${GEM_HOME}/cache/${GEM_NAME}.gem
 ${GEM_LIBDIR}/CODEOWNERS
@@ -2341,7 +2341,3 @@
 ${GEM_LIBDIR}/tasks/yard.rake
 ${GEM_HOME}/specifications/${GEM_NAME}.gemspec
 ${EGDIR}/puppet.conf
-${PLIST.sunos}lib/svc/method/svc-puppetd
-${PLIST.sunos}lib/svc/method/svc-puppetmasterd
-${PLIST.sunos}${EGDIR}/svc/puppet
-${PLIST.sunos}${EGDIR}/svc/puppet.xml