pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/mk/bulk According to egrep(1):



details:   https://anonhg.NetBSD.org/pkgsrc/rev/03d81227827a
branches:  trunk
changeset: 472429:03d81227827a
user:      jschauma <jschauma%pkgsrc.org@localhost>
date:      Sat Apr 10 16:23:00 2004 +0000

description:
According to egrep(1):
  Portability note: unlike GNU grep, traditional grep did not con-
  form to POSIX.2, because traditional grep lacked a -q option and
  its  -s option behaved like GNU grep's -q option.  Shell scripts
  intended to be portable to traditional grep should avoid both -q
  and -s and should redirect output to /dev/null instead.

And, guess what, that's exactly what we run into when we call IRIX'
egrep(1) with '-q' (which it doesn't know).  So let's follow this
suggestion and use neither '-q' nor '-s' and redirect output to
/dev/null instead.

diffstat:

 mk/bulk/bsd.bulk-pkg.mk |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (18 lines):

diff -r 83760ddb17c6 -r 03d81227827a mk/bulk/bsd.bulk-pkg.mk
--- a/mk/bulk/bsd.bulk-pkg.mk   Sat Apr 10 16:05:05 2004 +0000
+++ b/mk/bulk/bsd.bulk-pkg.mk   Sat Apr 10 16:23:00 2004 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: bsd.bulk-pkg.mk,v 1.59 2004/04/09 18:43:14 jschauma Exp $
+#      $NetBSD: bsd.bulk-pkg.mk,v 1.60 2004/04/10 16:23:00 jschauma Exp $
 
 #
 # Copyright (c) 1999, 2000 Hubert Feyrer <hubertf%NetBSD.org@localhost>
@@ -290,7 +290,7 @@
                                        fi; \
                                        if ${PKG_INFO} -qe $$pkgname ; then \
                                                ${SHCOMMENT} "Remove only unneeded pkgs" ; \
-                                               if ${EGREP} -q "^${PKGPATH} .* $$pkgdir( |$$)" ${DEPENDSFILE} ; then \
+                                               if ${EGREP} "^${PKGPATH} .* $$pkgdir( |$$)" ${DEPENDSFILE} >/dev/null 2>&1; then \
                                                        ${ECHO_MSG} "BULK> ${PKGNAME} requires installed package $$pkgname ($$pkgdir) to build." ;\
                                                else \
                                                        case "${BULK_PREREQ}" in \



Home | Main Index | Thread Index | Old Index