[pkgsrc/trunk]: pkgsrc/lang/go-bin go-bin: Hide the signing removal behind DA...

[jperkin <jperkin%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/e769454cc06c
branches:  trunk
changeset: 455926:e769454cc06c
user:      jperkin <jperkin%pkgsrc.org@localhost>
date:      Wed Jul 14 18:38:58 2021 +0000

description:
go-bin: Hide the signing removal behind DARWIN_CHROOTED.

Unfortunately stripping the signatures breaks running the binaries outside a
chroot according to schmonz, so we're left with no choice but to make this
user-configurable.  It took a lot of effort for me not to name this variable
something far ruder.

This will still mean the go-bin package is ultimately useless when shipped as
part of a package set, but really we only need it for bootstrapping a real
version which should work fine.

diffstat:

 lang/go-bin/Makefile |  9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diffs (23 lines):

diff -r ad60da48f078 -r e769454cc06c lang/go-bin/Makefile
--- a/lang/go-bin/Makefile      Wed Jul 14 17:58:40 2021 +0000
+++ b/lang/go-bin/Makefile      Wed Jul 14 18:38:58 2021 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.7 2021/07/14 14:31:21 jperkin Exp $
+# $NetBSD: Makefile,v 1.8 2021/07/14 18:38:58 jperkin Exp $
 
 PKGNAME=       go-bin-1.14.2
 PKGREVISION=   4
@@ -85,7 +85,12 @@
 
 do-install:
        cd ${WRKSRC} && ${PAX} -rw . ${DESTDIR}${PREFIX}/go-bin
-.if !empty(MACHINE_PLATFORM:MDarwin-*-aarch64)
+#
+# Removing the signatures is required to operate inside a chroot, but breaks
+# running them outside.  We're left with no choice but to make it configurable
+# by the user.
+#
+.if !empty(MACHINE_PLATFORM:MDarwin-*-aarch64) && defined(DARWIN_CHROOTED)
        for f in ${DESTDIR}${PREFIX}/go-bin/bin/* \
                 ${DESTDIR}${PREFIX}/go-bin/pkg/tool/darwin_arm64/*; do \
                /usr/bin/codesign --remove-signature $$f; \