[pkgsrc/trunk]: pkgsrc/net/librsync librsync: updated to 2.3.1

[adam <adam%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/bf144cb08c77
branches:  trunk
changeset: 445312:bf144cb08c77
user:      adam <adam%pkgsrc.org@localhost>
date:      Tue Jan 19 21:01:37 2021 +0000

description:
librsync: updated to 2.3.1

librsync 2.3.1

This is a patch release that adds peformance improvements, updates and tidies documentation, and fixes two build/test bugs on FreeBSD.


librsync 2.3.0

This is a minor release that adds rs_sig_args() for getting the recommended signature arguments based on the file size. which is used by rs_sig_file() and rdiff. This means rdiff by default will use 
a better block size based on the file size, and supports using --sum-size=-1 to use the smallest safe sum size (safe against random collisions, not against crafted hash-collision attacks). It removes 
old code that made the default strongsum size 8 when using --hash=md4, and it now defaults to 16 (the max for md4) for better protection against the risk of hash collision attacks and corruption. It 
also includes many code cleanups and testing improvements, including full C99 compliance. Upgrading from v2.2.1 is optional.

To generate signatures identical to the previous version's default arguments, you will need to use --block-size=2048 to select the old default block size. Also, when using --hash md4 you will need to 
add --sum-size=8 to select the old sum-size default when using md4 strongsums.


librsync 2.2.1

This is a patch release that fixes a bug that makes delta operations hang for files larger than 4GB. Upgrading from v2.2.0 is essential.


librsync 2.2.0

This is a minor release that adds RabinKarp rollsum support as the new recommended default. This is a much better rolling hash with a much better distribution and less collisions, particularly for 
text files and small blocks. This results in faster delta calculations and a reduced risk of corruption from hash collisions when using small strongsum sizes. It also includes important fixes for 
compiling on/for windows, and some other minor improvements. Upgrading from v2.1.0 is essential for people compiling for windows, recommended for people who want a performance increase, and otherwise 
not urgent.

To generate signatures compatible with previous versions of rdiff you will need to use the --rollsum rollsum to select the old rollsum algorithm, or for librsync use the RS_BLAKE2_SIG_MAGIC or 
RS_MD4_SIG_MAGIC arguments when starting the signature with rs_sig_begin().


librsync 2.1.0

This is a minor release that exposes a few useful utility functions to librsync.h previously only used by rdiff. It also introduces proper exporting of only public symbols in the librsync.h header. 
The most important fix is for a memory leak when freeing signatures. Upgrading from v2.0.2 is highly recommended for people using librsync and experiencing memory leak problems, but otherwise not 
urgent.

diffstat:

 net/librsync/Makefile                   |  10 +++++-----
 net/librsync/PLIST                      |   8 +++++---
 net/librsync/distinfo                   |  11 +++++------
 net/librsync/patches/patch-src_search.c |  16 ----------------
 4 files changed, 15 insertions(+), 30 deletions(-)

diffs (80 lines):

diff -r e7e6a298b28b -r bf144cb08c77 net/librsync/Makefile
--- a/net/librsync/Makefile     Tue Jan 19 19:00:02 2021 +0000
+++ b/net/librsync/Makefile     Tue Jan 19 21:01:37 2021 +0000
@@ -1,19 +1,19 @@
-# $NetBSD: Makefile,v 1.8 2020/08/31 18:10:35 wiz Exp $
+# $NetBSD: Makefile,v 1.9 2021/01/19 21:01:37 adam Exp $
 
-DISTNAME=      librsync-2.0.0
-PKGREVISION=   4
+DISTNAME=      librsync-2.3.1
 CATEGORIES=    net
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=librsync/}
 GITHUB_TAG=    v${PKGVERSION_NOREV}
 
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=      http://librsync.sourcefrog.net/
-COMMENT=       rsync-like rolling checksum library
+COMMENT=       Rsync-like rolling checksum library
 LICENSE=       gnu-lgpl-v2.1
 
 USE_CMAKE=     yes
+USE_LANGUAGES= c c++
 USE_TOOLS+=    perl
-USE_LANGUAGES= c c++
+TEST_TARGET=   test
 
 .include "../../archivers/bzip2/buildlink3.mk"
 .include "../../devel/popt/buildlink3.mk"
diff -r e7e6a298b28b -r bf144cb08c77 net/librsync/PLIST
--- a/net/librsync/PLIST        Tue Jan 19 19:00:02 2021 +0000
+++ b/net/librsync/PLIST        Tue Jan 19 21:01:37 2021 +0000
@@ -1,7 +1,9 @@
-@comment $NetBSD: PLIST,v 1.2 2016/09/01 16:16:55 wiz Exp $
+@comment $NetBSD: PLIST,v 1.3 2021/01/19 21:01:37 adam Exp $
 bin/rdiff
-include/librsync-config.h
 include/librsync.h
+include/librsync_export.h
 lib/librsync.so
+lib/librsync.so.${PKGVERSION}
 lib/librsync.so.2
-lib/librsync.so.2.0.0
+man/man1/rdiff.1
+man/man3/librsync.3
diff -r e7e6a298b28b -r bf144cb08c77 net/librsync/distinfo
--- a/net/librsync/distinfo     Tue Jan 19 19:00:02 2021 +0000
+++ b/net/librsync/distinfo     Tue Jan 19 21:01:37 2021 +0000
@@ -1,7 +1,6 @@
-$NetBSD: distinfo,v 1.5 2016/09/20 08:26:50 wiz Exp $
+$NetBSD: distinfo,v 1.6 2021/01/19 21:01:37 adam Exp $
 
-SHA1 (librsync-2.0.0.tar.gz) = c24a623bba5f9eae48bd3b6cb99ee43d2a40b8c6
-RMD160 (librsync-2.0.0.tar.gz) = f44284c0d33b9fb6a9b8c107169549cf2d121273
-SHA512 (librsync-2.0.0.tar.gz) = 1a88dcc3aa60949e058c57eb0df3e0086823c493de40fed927246f5aada6274db57202074456a0ce5d9aa8b81b41836b0d6221ded6a75d43829572584177e8c0
-Size (librsync-2.0.0.tar.gz) = 155049 bytes
-SHA1 (patch-src_search.c) = 8da2885849e39999f36f9d7ce3824bc177033a53
+SHA1 (librsync-2.3.1.tar.gz) = 5127c8fa462b741f4943ece679bf83615cc47c17
+RMD160 (librsync-2.3.1.tar.gz) = 0df16b7027dfa1123e391aaa66cf62d8b8ad6397
+SHA512 (librsync-2.3.1.tar.gz) = 89e5b5ad960b8036acce41df09f5e50601d7eb57d48a2bd21c4ee54a3a375f62ee514036b9a562277b5656735b84cadf6f54cbf48c364bbf0c04f2d95ae3b5a6
+Size (librsync-2.3.1.tar.gz) = 194573 bytes
diff -r e7e6a298b28b -r bf144cb08c77 net/librsync/patches/patch-src_search.c
--- a/net/librsync/patches/patch-src_search.c   Tue Jan 19 19:00:02 2021 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,16 +0,0 @@
-$NetBSD: patch-src_search.c,v 1.1 2016/09/20 08:26:50 wiz Exp $
-
-librsync has a crash in rs_search_for_block documented here:
-https://github.com/librsync/librsync/issues/50
-
---- src/search.c.orig  2015-11-29 20:43:12.000000000 +0000
-+++ src/search.c
-@@ -218,7 +218,7 @@ rs_search_for_block(rs_weak_sum_t weak_s
-           r = m;
-     }
- 
--    if (l == r) {
-+    if ((l == r) && (l <= bucket->r)) {
-       int i = sig->targets[l].i;
-       rs_block_sig_t *b = &(sig->block_sigs[i]);
-       if (weak_sum != b->weak_sum)