pkgsrc-Bulk archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Proposed changes in the build.conf file



After a hard time finding out what the several variables in the bulk.conf file do, I'd like to rename some of them (as usual). The patch I propose to build.conf-example is:

----snip----
-# Some paths for output files and paths to log files
-FTPx=`date +%Y%m%d.%H%M`
-FTPURL="pub/NetBSD/pkgstat/${FTPx}"            # relative to ~ftp !
-FTP="/home/ftp/${FTPURL}"                      # absolute base path
-FTPHOST="ftp://ftp.machi.ne";                   # host for broken.html
+# REPORT_DIR is the directory on the build machine where the
+# report files are copied to. Uploading these files to a public FTP or
+# HTTP server must be done manually. REPORT_URL is the URL where the
+# report files will be reachable after uploading. This URL is only used
+# for being printed in the text/plain report. bc_common_path is a helper
+# variable and is not examined by the bulk build programs.
+bc_common_path="`date +%Y%m%d.%H%M`"
+REPORT_DIR="$HOME/bulk-reports/${bc_common_path}"
+REPORT_URL="ftp://my.ftp.server.local/pub/NetBSD/pkgstat/${bc_common_path}";
----snip----

Is it correct that using REPORT_URL="${FTPHOST}/${FTPURL}" and REPORT_DIR="${FTP}" would provide the needed backwards compatibility, or have I overseen anything?

----snip----
-
-###########################################################################
-### No changes should be needed below this line !!!
-###########################################################################
-
-# Name of the (generated) HTML file which lists all broken pkgs
-REPORT="$FTP/broken.html"
----snip----

I think this variable should be placed into bsd.pkg-bulk.mk into the section where the other variables for files in ${BULKFILESDIR} live. The report should be generated in that directory, too, and only later be copied to the REPORT_DIR, together with all the other files.

Roland



Home | Main Index | Thread Index | Old Index